Skip to content

Conversation

joshreisner
Copy link
Contributor

this PR allows sites to leave out the data-timezone and have meeting times translated into the user's timezone

meetings would be required to provide their own timezone in the right format

it would not have TSML support initially, since TSML:

  • doesn't store timezone information for meetings
  • always specifies timezone in its embed shortcode

closes #248

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit 67431c7
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/631a07fb37d32a0007095df7
😎 Deploy Preview https://deploy-preview-251--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshreisner
Copy link
Contributor Author

i have two concerns so far about this PR:

  1. there's currently no outward indication that the timezone has been translated. i added times to the meeting names, but presumably most sites would not do this. i'm not sure how important it is for online meetings, but for in-person ones (if i'm planning a trip, say) then this should probably be flagged in the interface somewhere

  2. this makes it so if you do specify a timezone the times all get normalized to that timezone. this could present a problem on a site that currently displays meetings across a range of timezones such as Continental European Region (they are currently not using TSML UI, but maybe we should contact them about this change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate meeting times into user's timezone

1 participant