add a default duration for when end not specified #259
Conversation
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
thanks! i will check this out with sites currently using TSML UI who are not supplying end times, to see if they are comfortable with this update changes look great overall, some small bits of feedback:
|
|
got prettier installed and formatted, undid the google change but wasn't sure what to do on "in format-ics i think we can just remove the end_time logic now" Also thoughts on an issue to add prettier as dev dependency and npm command to run it? |
src/helpers/format/format-ics.ts
Outdated
| //need an end time. use default if none specified | ||
| if (!meeting.end) { | ||
| meeting.end = meeting.start.plus({ hour: 1 }); | ||
| meeting.end = meeting.start.plus({ minutes: settings.defaults.duration }); | ||
| } |
There was a problem hiding this comment.
this is what i was referencing. now that we are supplying end times, i think this set of lines can now just be
if (!meeting.start || !meeting.end) return;
|
left a comment on sounds great on creating an issue to add prettier as dev dependency and npm command to run it -- i wasn't aware that was possible |
|
Oops sorry been swamped last two days got the issue in though. Any other fixes needed after your commit? |
|
Hey, no, should be all good now. I just have to give AA SF / Marin a few days to implement end times if they want to. Looking to merge on Sunday / Monday |
* add a default duration for when end not specified * add a default duration for when end not specified * undo google changes * final tweaks * fix test Co-authored-by: Josh Reisner <1551689+joshreisner@users.noreply.github.com>
2 participants
Addresses #245