Skip to content

Conversation

tiptop96
Copy link
Collaborator

Hey, I am adding a Swedish locale but I have some questions!

  • In what contexts are appointment and midday used?
  • I have translated the descriptions of C and O to be substance agnostic (because it works for CA), is this an issue? Like if AA Sweden were to start using it.

@netlify
Copy link

netlify bot commented Feb 18, 2023

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit 525e8ee
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/63f12e194de6860008d34b17
😎 Deploy Preview https://deploy-preview-292--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshreisner
Copy link
Contributor

great thanks!

midday is in the time filter dropdown, it means the span of time between 11am and 3pm
appointment is used when there is no time for a meeting, it presumably can be scheduled 'by appointment'
it would be ideal to translate as is and then override for your locale.

@joshreisner
Copy link
Contributor

code looks good! couple notes:

you'll want to build it with a npx build --production
please increment the version in package.json and run npm i so that it also updates package-lock

@tiptop96
Copy link
Collaborator Author

Thanks!

Cool, I translated them pretty much word for word now.

It is funny, there is no single word for midday in Swedish. 😅

I did npx mix --production, does it look right?

@tiptop96 tiptop96 marked this pull request as ready for review February 18, 2023 18:57
@joshreisner joshreisner merged commit 58029fc into code4recovery:main Feb 18, 2023
joshreisner added a commit that referenced this pull request Jun 2, 2023
* Swedish, fellowhip neutral translations draft

* additions

* add to index

* wrap things up

* enabling lang

---------

Co-authored-by: Gustav Eiman <gustav.eiman@svt.se>
Co-authored-by: Josh Reisner <1551689+joshreisner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants