Skip to content

Conversation

Hiro-Tokyo
Copy link
Contributor

I made some Japanese translation changes.

I made some Japanese translation changes.
@netlify
Copy link

netlify bot commented Jun 3, 2023

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit b9c2fc2
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/647b5c0c95fbef0008f58527
😎 Deploy Preview https://deploy-preview-308--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshreisner
Copy link
Contributor

thanks hiro! it would be good to build assets as part of this PR. please

  1. install NPM if it is not installled
  2. run npm i in the project folder
  3. run npx mix --production in the project folder

i have expanded the section of the readme about developing if you would like to preview your changes locally: https://github.com/code4recovery/tsml-ui#contributing

@Hiro-Tokyo
Copy link
Contributor Author

Thanks Josh! How I can do this alert,"This branch is out-of-date with the base branch"? Or should I install NPM first?
Screenshot 2023-06-03 at 23 46 22

@joshreisner
Copy link
Contributor

probably click that "update branch" button

@Hiro-Tokyo
Copy link
Contributor Author

Okay I did it!

@Hiro-Tokyo
Copy link
Contributor Author

Hiro-Tokyo commented Jun 3, 2023

Seems reverted!
Screenshot 2023-06-04 at 8 04 41

@joshreisner
Copy link
Contributor

i'm not sure what that means, but i'll go ahead and build it this time

ideally next time there would be two files updated - ja.ts and app.js

@joshreisner joshreisner merged commit 47db3b1 into code4recovery:main Jun 4, 2023
@Hiro-Tokyo
Copy link
Contributor Author

Hiro-Tokyo commented Jun 4, 2023

Thank you Josh! I meant 'seems reverted'.

So I do not have to do anymore this time?

I will have a meeting with Japan online intergoup's new webmaster so we will try to figure out about building assets, compile. Then I will let you know!

@joshreisner
Copy link
Contributor

sounds good! yes nothing more to do - it should be updated now

@Hiro-Tokyo
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants