Fix near location search #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michael-duren
approved these changes
Nov 10, 2023
| state.input.mode === 'location' ? search : state.input.search | ||
| } | ||
| /> | ||
| <input type="submit" hidden /> |
There was a problem hiding this comment.
Makes sense to add this.
Also not sure how this was working before the enter key press behavior seems sort of unpredictable currently.
There was a problem hiding this comment.
I think maybe because there are buttons in the
field the browser might be interpreting one of those as a submit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is weird, i'm not sure how long "near location" search has not been working
seems the problem is
onSubmitis not firing, the simplest solution i found was to add a hidden submit buttonalternately we could listen for the enter key in the input onChange and fire locationSearch if
mode === "location"could not tell from the history when this stopped working
closes #342