recursively hoist regions that duplicate their parent #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joshreisner
changed the title
gkovats
approved these changes
Aug 23, 2025
joshreisner
deleted the
368-regions-dont-show-when-top-level-region-is-always-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #368
the main problem this ticket tries to solve is: currently TSML UI will not show the regions dropdown if it's all grouped by a single top-level region. the reason for this is that we remove filters that apply to every meeting. (if every meeting was in the morning, for example, we would not show the Any Time filter because it would not have any utility)
this solves this by removing regions that have all the meetings of their parent region. this has the effect of "hoisting" regions to be more useful. for example:
becomes