Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block level nesting audit #67

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

SamusElderg
Copy link
Collaborator

Mainly to solve #63 but did a bunch of other common audits while there, wasn't much to action 🥳

Closes #63

leo95oliveira and others added 4 commits May 14, 2024 12:44
paragraph element audit
- replaced any `<p>` elements with `<div>` if they can theoretically hold a child block level element
removed one instance of an unneeded console.log
added one instance of an img with missing alt
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:07am

@SamusElderg SamusElderg changed the base branch from main to develop May 17, 2024 15:24
Copy link
Contributor

@leo95oliveira leo95oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just remember to update the package.json version to 4.0.3 so that you can create the package release for it :)

- bumped version to 4.0.3 for release
@SamusElderg SamusElderg merged commit ec62a92 into develop May 21, 2024
4 checks passed
@SamusElderg SamusElderg deleted the samus/block-level-nesting-audit branch May 21, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContestTile invalid nested elements
2 participants