Add card component #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leo95oliveira
suggested changes
Sep 27, 2023
There was a problem hiding this comment.
This component looks awesome @captainmangoC4! I've requested some very minor changes but other than that it should be ready to go! Once the changes have been made just let me know and I'll approve the PR 😄
On a side note, looking at the component on Storybook, I noticed that it seems to have a fixed width; did you add any CSS related to responsiveness for the component? Just asking because if you did add it and it's not reproducing properly on Storybook, I might have to look into it to see what the issue is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generic card component can be used for the contest tile, the reports tile, and for the team members tab in the new team profile