Fix Ch. 14 Account practice problem, fix package name in Ch. 13 Negative Sum practice problem #25

phrdang · 2021-07-01T18:22:06Z

Changes

Ch. 14.7 Account practice problem
- Consolidate into 1 class called Account.java
- Clarify instructions and post instructions in the file
- Close Scanner object when done
- NOTE: I have already updated the instructions on Notion for this problem, but the template and solution code links are wrong
Ch. 13.5 Negative Sum practice problem
- Fix solution package statement

Also implements changes in #24 due to a git mess up (I accidentally branched from selection-sort-solution).

- Consolidate into 1 class called Account.java - Clarify instructions and post instructions in the file - Close Scanner object when done

Fixed a couple identation things and formatting on the createAccount method where parameters are initialized

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2021-07-01T21:28:56Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+        System.out.println("Welcome to Account Creation!");
+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:28:57Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        System.out.println("Welcome to Account Creation!");
+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:28:57Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();
+          System.out.print("Enter age: ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:28:57Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();
+          System.out.print("Enter age: ");
+          int age = sc.nextInt();


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:28:57Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+          String username = sc.next();
+          System.out.print("Enter age: ");
+          int age = sc.nextInt();
+          System.out.print("Enter password (4 to 10 characters): ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:28:59Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+    }
+
+    public static void createAccount(String username, int age, String password, String confirmPassword)
+      throws InvalidAgeException, InvalidPasswordException, InvalidUsernameException, PasswordMismatchException {


[reviewdog] _{reported by reviewdog 🐶}
'throws' has incorrect indentation level 6, expected level should be 8.

github-actions · 2021-07-01T21:28:59Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        if (!password.equals(confirmPassword)) {
+            throw new PasswordMismatchException();
+        }
+      }


[reviewdog] _{reported by reviewdog 🐶}
'method def rcurly' has incorrect indentation level 6, expected level should be 4.

github-actions · 2021-07-01T21:28:59Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+      }
+}
+
+class InvalidUsernameException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidUsernameException has to reside in its own source file.

github-actions · 2021-07-01T21:28:59Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+class InvalidUsernameException extends Exception {}
+
+class InvalidPasswordException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidPasswordException has to reside in its own source file.

github-actions · 2021-07-01T21:28:59Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+class InvalidPasswordException extends Exception {}
+
+class InvalidAgeException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidAgeException has to reside in its own source file.

Identation fix again

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2021-07-01T21:34:02Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+        System.out.println("Welcome to Account Creation!");
+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:34:03Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        System.out.println("Welcome to Account Creation!");
+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:34:03Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        while (true) {
+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();
+          System.out.print("Enter age: ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:34:03Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+          System.out.print("Enter username (4 to 10 characters): ");
+          String username = sc.next();
+          System.out.print("Enter age: ");
+          int age = sc.nextInt();


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:34:03Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+          String username = sc.next();
+          System.out.print("Enter age: ");
+          int age = sc.nextInt();
+          System.out.print("Enter password (4 to 10 characters): ");


[reviewdog] _{reported by reviewdog 🐶}
'while' child has incorrect indentation level 10, expected level should be 12.

github-actions · 2021-07-01T21:34:05Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+    }
+
+    public static void createAccount(String username, int age, String password, String confirmPassword)
+      throws InvalidAgeException, InvalidPasswordException, InvalidUsernameException, PasswordMismatchException {


[reviewdog] _{reported by reviewdog 🐶}
'throws' has incorrect indentation level 6, expected level should be 8.

github-actions · 2021-07-01T21:34:05Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+        if (!password.equals(confirmPassword)) {
+            throw new PasswordMismatchException();
+        }
+      }


[reviewdog] _{reported by reviewdog 🐶}
'method def rcurly' has incorrect indentation level 6, expected level should be 4.

github-actions · 2021-07-01T21:34:05Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+      }
+}
+
+class InvalidUsernameException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidUsernameException has to reside in its own source file.

github-actions · 2021-07-01T21:34:05Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+class InvalidUsernameException extends Exception {}
+
+class InvalidPasswordException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidPasswordException has to reside in its own source file.

github-actions · 2021-07-01T21:34:06Z

src/com/codefortomorrow/advanced/chapter14/solutions/Account.java

+
+class InvalidPasswordException extends Exception {}
+
+class InvalidAgeException extends Exception {}


[reviewdog] _{reported by reviewdog 🐶}
Top-level class InvalidAgeException has to reside in its own source file.

AlveeraMunshi

Realized the bot has its own ideas regarding indentation as it seems to keep changing something I did back LOL. I was trying to fix Lines 53-57 on Account.java in the solutions folder. But If that's how it wants then all good looks fine otherwise to me.

Fixed the indentation with the right level

phrdang added 3 commits June 30, 2021 18:13

Add actual TestSelectionSort solution

e0b585a

Fix package statement

bc785e4

Fix Account exception handling problem

87dc112

- Consolidate into 1 class called Account.java - Clarify instructions and post instructions in the file - Close Scanner object when done

phrdang added bug Something isn't working practice problem labels Jul 1, 2021

phrdang requested review from AlveeraMunshi and JJ27 July 1, 2021 18:22

Bot: Prettified Java code!

57e5e97

phrdang removed the request for review from JJ27 July 1, 2021 20:20

AlveeraMunshi and others added 2 commits July 1, 2021 17:27

Update Account.java

1a305eb

Fixed a couple identation things and formatting on the createAccount method where parameters are initialized

Bot: Prettified Java code!

f80f9d3

github-actions bot reviewed Jul 1, 2021

View reviewed changes

AlveeraMunshi and others added 2 commits July 1, 2021 17:32

Update Account.java

cef8163

Identation fix again

Bot: Prettified Java code!

956906c

github-actions bot reviewed Jul 1, 2021

View reviewed changes

AlveeraMunshi approved these changes Jul 1, 2021

View reviewed changes

Update Account.java

49d5566

Fixed the indentation with the right level

phrdang merged commit 1bc9537 into master Jul 1, 2021

phrdang deleted the fix-account branch July 1, 2021 22:03


		class InvalidUsernameException extends Exception {}

		class InvalidPasswordException extends Exception {}


		class InvalidPasswordException extends Exception {}

		class InvalidAgeException extends Exception {}

Uh oh!

Fix Ch. 14 Account practice problem, fix package name in Ch. 13 Negative Sum practice problem #25

Fix Ch. 14 Account practice problem, fix package name in Ch. 13 Negative Sum practice problem #25

Uh oh!

Conversation

phrdang commented Jul 1, 2021

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

AlveeraMunshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!