Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for Caesarcipher in Python #94

Merged
merged 5 commits into from Dec 8, 2017

Conversation

@rahulkumaran
Copy link
Contributor

commented Dec 6, 2017

This is a code for Caesarcipher in Python.
You can test the following code by compiling it and then giving a string and a key value and accordingly the encryption and decryption will take place.

@prateekiiest prateekiiest requested a review from soubh1k Dec 7, 2017

@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

same as #113

@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

@prateekiiest I've been working on the Ceasarcipher since the beginning! And moreover this code is in Python! Could I know why the duplicate tag ?

@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

Its not that you cant add the same code.
It would be better if you could create a separate folder for both the languages :)

@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

So under the crypto algos folder, do you want me to create a separate folder called "crypto algos in Python" or do you just want me to create a separate folder for the implementation of "Caesar Cipher in Python" ? :)

@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

just create Python and under that insert the code

@soubh1k
Copy link
Collaborator

left a comment

Just need a slight change. Instead of explicitly asking the user for an input, initialise a key and string within the program.

rahulkumaran added some commits Dec 8, 2017

Separate Python folder with Caesarcipher Algorithm
Created a separate 'Python' folder under the cryptography folder and put the implementation of Caesarcipher in that folder.
Also gave a custom input value for key and a custom string for encrypting and decrypting too.
@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2017

@prateekiiest @soubh1k made the necessary changes.
Please do have a look at it.
Created a separate Python folder under the Cryptography folder and also initialised the key value and the strings to be encrypted and decrypted.

@prateekiiest
Copy link
Member

left a comment

do like this
CaesarCipher/Python/Caesarcipher.py

@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

under RSA

@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2017

The Caesarcipher should be under the crypto folder right? @prateekiiest

rahulkumaran added some commits Dec 8, 2017

Added a Caesarcipher folder under crypto
Added a CaesarCipher folder, a python folder inside and inside that my code for the implementation of Caesarcipher(Caesarcipher.py)
@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

yes under RSA folder

@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2017

@prateekiiest added the code under /CaesarCipher/Python/Caesarcipher.py

@prateekiiest prateekiiest merged commit 4a3a56e into codeIIEST:master Dec 8, 2017

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codebeat no reportable quality changes
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rahulkumaran rahulkumaran deleted the rahulkumaran:rahulkumaran-patch-CC branch Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.