Skip to content

[CM-1275] Implements List Models Entrypoint #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2023
Merged

[CM-1275] Implements List Models Entrypoint #56

merged 5 commits into from
Mar 29, 2023

Conversation

osugikoji
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Creates list models entrypoint based on the following ticket: https://ymedialabs.atlassian.net/browse/CM-1275

  • Adds sample to showcase on android and JVM
  • Adds new unit tests
  • Adjust javadoc

💚 How did you test it?

Tested on JVM and Android samples

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

📸 Screenshots / GIFs

Android Sample

@osugikoji osugikoji requested a review from xyzwilliamxyz March 29, 2023 19:35
@osugikoji osugikoji requested a review from kikoso as a code owner March 29, 2023 19:35
@osugikoji osugikoji merged commit 0da7aba into main Mar 29, 2023
@osugikoji osugikoji deleted the feature/CM-1274/list-models branch March 29, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoso kikoso Awaiting requested review from kikoso

1 more reviewer

@xyzwilliamxyz xyzwilliamxyz xyzwilliamxyz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osugikoji @xyzwilliamxyz