fix: listable_spec flaky scope test - introduce match_array #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notapatch
force-pushed
the
pr-listable_spec_flaky
branch
from
63bdbc4 to
04869bd
Compare
notapatch
changed the title
notapatch
force-pushed
the
pr-listable_spec_flaky
branch
from
04869bd to
6efd456
Compare
notapatch
changed the title
notapatch
force-pushed
the
pr-listable_spec_flaky
branch
from
6efd456 to
e75f481
Compare
matyikriszta
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
@notapatch thanks for the fix 👍, this needs a rebase but otherwise good to go.
- Problem:
- the tests fabricate three future workshops without specifying
an order
- the test asserts that three future workshops appear in date
order
- Fix: test asserts workshops are present but not the order of
appearance
notapatch
force-pushed
the
pr-listable_spec_flaky
branch
from
e75f481 to
4a1e423
Compare
|
I change only test code and coverage has decreased?? Say what now. |
|
@notapatch yes, sometimes it does that and I have no idea why, this really shouldn't decrease coverage in my opinion. I'm still happy to merge it if you are. I'm going to look into whether we can set the threshold for reporting decrease to a higher number, like maybe 0.5% or so. |
|
Absolutely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke PR #1056 earlier today on "#upcoming returns a list of all upcoming workshops" but its sibling test could have just as easily broken
note: the bot forced pushed a couple of hours later and passed the second time