Skip to content

Email updates #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2020
Merged

Email updates #1271

merged 4 commits into from
May 13, 2020

Conversation

despo
Copy link
Member

@despo despo commented May 12, 2020 •
edited
Loading

  1. Update Virtual workshop attendance and attendance reminder emails to include joining information instead of linking to invitation page (screenshots attached below)
  2. Use WorkshopPresenter#address in emails instead of setting up @host_address separately
  3. Remove non utilised change_of_details email (out of date email and content, it would be easier to reimplement if needed)

attendance-reminder

attendance-confirmation

despo added 4 commits May 12, 2020 23:26
@despo
(enhancement) Add joining info in attendance email
ddb8e9e
@despo
(update) Update virtual workshop attendance confirmation and attendan…
0074fdc 
…ce reminder

to include how to join details.
@despo
(enhancement) use address from WorkshopPresenter
eb0ce9a
@despo
(refactoring) remove change_of_details email
12ef3b8 
Using old style and has not been used in years. It would be less effort to recreate than to try to update this.
@despo despo requested a review from matyikriszta May 12, 2020 22:31
matyikriszta
matyikriszta approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@matyikriszta matyikriszta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@despo despo merged commit 7ddcc7a into codebar:master May 13, 2020
@despo despo deleted the email-updates branch May 13, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyikriszta matyikriszta matyikriszta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@despo @matyikriszta