Replace will_paginate gem with pagy gem #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyikriszta
force-pushed
the
replace-will-paginate-with-pagy
branch
from
697e4d3 to
f5f7b8d
Compare
BPScott
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The will_paginate pagination no longer works, as reported in #1928 (the links are malformed, I did not manage to figure out why). I'd also like to make use of the Bootstrap pagination styles for our pagination, and will_paginate does not support CSS frameworks out of the box. For these reasons I decided to replace the will_paginate gem with the pagy gem that comes with Bootstrap support.
Status
Ready for Review
Screenshots