Skip to content

PHP Tutorial lesson 2 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

kodikos
Copy link

@kodikos kodikos commented Dec 8, 2018

This is to add a 2nd part to the PHP tutorial. I have also tweaked other areas of the PHP tutorial area:

  • Moved using PHP into its own page of simple installation and usage (a more complex discussion will follow)
  • Addition of lesson 2 page on values and variables
  • Tweaks to lesson 1 to point out to the simple guide
  • Removing refs to cloud9 (no longer free, or simple to use!)
  • Updated main index page to advertise tutorial 2

@brunogirin
Copy link
Contributor

I like the new page that explains how to install PHP. Will that install 5.x or 7.x and is there any need to mention version numbers at any point?

@kodikos
Copy link
Author

kodikos commented Dec 21, 2018

Thanks for looking in, @brunogirin :) You raise an interesting point. I was linking to the PHP instructions thinking it would point to latest installs in a system-dependent way with package managers, but they appear to be mainly showing how to install the 5.x version.. boo :( I think I'll need to add some explicit notes to get everyone installing 7, but might need help on the mac instructions (would brew instructions be sufficient?). phpFiddle is 7.0.x at time of writing. Generally, I don't think the tutorials yet hit any differences, but as I'm bit of a newbie to 7, I'll try to keep an eye out. I wanted to keep the tutorials relatively simple, so hopefully won't come across too much that's incompatible, and I'll always go with the 7.x way of doing things, and add a note about assuming this.

@KimberleyCook
Copy link
Contributor

@kodikos @brunogirin am I good to merge this in?

@brunogirin
Copy link
Contributor

@KimberleyCook yes you are, thanks!

@kodikos
Copy link
Author

kodikos commented Mar 12, 2019

The installer instructions are not ideal, but it's more a problem with the PHP documentation than ours. It probably also needs a rebase with master as it mods the tutorials index. Thanks @KimberleyCook

@kodikos
Copy link
Author

kodikos commented Mar 12, 2019

I've just rebased with master. Found out that macs (high sierra+) already have PHP7 installed :)

Copy link
Contributor

@KimberleyCook KimberleyCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, thank you so much for this @kodikos and apologies for the delay in getting it merged in.

@KimberleyCook KimberleyCook merged commit aa131f6 into codebar:gh-pages Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants