Skip to content

support custom http client for subscription client #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

sermojohn
Copy link

This PR allows customising the http client used by the subscription client. This enables among other uses, the customisation of the TLS config, so self-signed certificates are accepted by the client, when the api-gateway terminates TLS with self-signed certificates.

@sermojohn sermojohn requested a review from vkotronis February 18, 2022 08:32
Copy link

@vkotronis vkotronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sermojohn sermojohn merged commit 838e6bd into master Feb 18, 2022
@sermojohn sermojohn deleted the customise-httpclient branch February 21, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants