Various additions and fixes. #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 4, 2016 11:22
chrome-app-1.0.0.8.zip will be installed on chrome browser during webdriver creation.
When browserName is chrome, webdriver installs the codebender app.
Updated version and seleniumVersion variables so that selenium tests can run on chrome.
Added global variable BROWSER with default value firefox that updates its value from capabilities.yaml browserName parameter. Added user agent on Chrome browser for Linux, Windows and Mac to test walkthrough pages, on each OS.
Files that were affected: conftest.py, test_sketch.py. The requires_extension fixture was removed since now we are able to install Chrome extension on Chrome versions > 41 and there is no need to skip tests that require extension when running tests under Chrome.
Logout now waits for Log in button to be visible.
The function now waits until the uploaded project is found.
seleniumbender: Removed argument "--source" from tox commands.
config.py: Removed TEST_CREDENTIALS used when logging into the bachelor site.
Removed names of sources used to generate the codebender site.
utils.py: Removed reference to TEST_CREDENTIALS in function login.
Updated comment related to bachelor site in function compile_sketch.
conftest.py: Removed fixture requires_source since we have only codebender_cc source used
to generate codebender site.
Removed fixture source used to specify the source repository from which the
site was derived (e.g. bachelor or codebender_cc).
Removed Removed parser.addoption "--source" used to indicate the source used
to generate the site.
Removed TEST_CREDENTIALS used as default value in testing_credentials
function.
test_home.py: Removed TEST_CREDENTIALS used for bachelor site from test_login function.
test_user_home.py: Removed functions test_create_project_blank_name,
test_create_project_invalid_name, test_create_project_valid_name since
the way that a project is created when Create sketch button is clicked
has changed.
Removed @pytest.mark.requires_source(SOURCE_CODEBENDER_CC).
Files affected: conftest.py, test_alerts.py. This marker is used so that we skip tests when running under chrome since we have an unexpected behavior when the extension is not installed.
| @@ -73,40 +73,43 @@ NO_LOGS=0 # flag for tests that do not send any logs on their email | |||
|
|
|||
There was a problem hiding this comment.
Please remove SOURCE="codebender_cc" at line 67 as it is not used any more.
There was a problem hiding this comment.
@tsiknas Are we still using this script? I thought it became obsolete after the new seleniumbender in python
There was a problem hiding this comment.
@dastergon Kept it until the seleniumbender in Python completes and we start using it.
added 3 commits
February 12, 2016 17:23
BROWSER variable is already initialised to "firefox", its assignment after checking that browser_name="firefox" can be omitted.
The variable was removed since it is not used anymore.
Konstantinacc
force-pushed
the
tests_additions_and_fixes
branch
from
56a0872 to
d6138ee
Compare
|
@tsiknas: Your comments have been fixed in commits: @dastergon: Comments related to test_walkthrough.py will be corrected by tsiknas to pr#22. |
|
Looks good to me 👍 |
dastergon
added a commit
that referenced
this pull request
Feb 15, 2016
Various additions and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments to config.py file.
Deleted codebender-app.crx from extensions/ directory.
Added codebender chrome app version 1.0.0.8 to extensions/ directory.
Updated create_webdriver function to install chrome codebender app.
Updated capabilities.yaml for chrome browser.
Fixed test for walkthrough pages on Chrome browser.
Removed @pytest.fixture requires_extension.
Modified logout function in utils.py file.
Updated function _upload_test in test_user_home.py file.
Removed code used in bachelor site.
Added @pytest.fixture does_not_require_extension.
Omitted BROWSER variable assignment when browser is firefox.
Added missing identifier codebender-selenium at the Chrome UA.
Removed SOURCE variable from seleniumbender.