Push State #115
Closed
Push State #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| template 'router.coffee', File.join(backbone_path, "routers", class_path, "#{plural_name}_router.js.coffee") | ||
| def create_router_files | ||
| if options[:pushstate] | ||
| template 'router_ps.coffee', File.join(backbone_path, "routers", class_path, "#{file_name}_router.js.coffee") |
There was a problem hiding this comment.
should be written as "plural_name"? (but practically no problem)
|
Any other problem? |
|
@zamith nice addition! any chance you want to bring you'd want to bring the funcitonality into this - http://westonplatter.com/railsy_backbone? I'd love to work through the PR with whatever help you need, tests and such. |
|
@westonplatter Hey, thanks for the comment, but right now I don't have the time to work on this, since I've been parting ways with backbone. Hope the project goes well, though. |
|
@zamith cool. found better solutions? |
|
Not really. Mostly just rails. |
|
@zamith and, it looks like Rails Engines. 👍 https://leanpub.com/start-engines?utm_campaign=start-engines&utm_medium=embed&utm_source=zamith.pt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added push state compliant templates that can be used by passing a flag to your generators. I've also updated the README to take this into account.
I haven't written any tests yet, sorry for that. But if you really want them I can try too make some time to do them.