Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable github cache for mvn dependencies #1677

Closed
ccoltx opened this issue Mar 28, 2021 · 5 comments · Fixed by #1687
Closed

Enable github cache for mvn dependencies #1677

ccoltx opened this issue Mar 28, 2021 · 5 comments · Fixed by #1687
Labels
enhancement
Milestone
2.4.1

Comments

@ccoltx
Copy link
Contributor

ccoltx commented Mar 28, 2021

Decrease build times and improve build reliability, enable the github cache action for mvn dependencies.

https://github.com/actions/cache
https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows
@ccoltx ccoltx mentioned this issue Mar 28, 2021
Closed
ccoltx added a commit that referenced this issue Mar 28, 2021
@ccoltx
Cache mvn repo in main build (see #1677 )
d5423a7
@jonashackt
Copy link
Member

LGTM! :) What is this annoying

Error:  Plugin pl.project13.maven:git-commit-id-plugin:4.0.3 or one of its dependencies could not be resolved: Failed to read artifact descriptor for pl.project13.maven:git-commit-id-plugin:jar:4.0.3: Could not transfer artifact pl.project13.maven:git-commit-id-plugin:pom:4.0.3 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/pl/project13/maven/git-commit-id-plugin/4.0.3/git-commit-id-plugin-4.0.3.pom: Connection timed out (Read failed) -> [Help 1]

all about? Is there a problem with Maven Central access? Should we upgrade to the latest 4.0.4? I don't really get the error really... since why does this dependency fail and not others if there were a Maven Central bug...?

@Riggs333
Copy link
Contributor

The update to version 4.0.4 of the git-commit-id-plugin does not seem to help, see PR #1663.
Same error message during the build. :-(
But the build fails only on one of the four checks. 🤔

@jonashackt
Copy link
Member

What for do we use the git-commid-id-plugin? Maybe we could get rid of it...?

@joshiste
Copy link
Collaborator

What for do we use the git-commid-id-plugin? Maybe we could get rid of it...?

It creates a git.properties file in the sample applications. This information is automatically picked up by spring boot and served on the info endpoint.
So the plugin is not vital but shows a simple way for an integration to get the git information in SBA

ccoltx added a commit that referenced this issue Mar 29, 2021
@ccoltx
Cache mvn repo in main build (see #1677 )
c40a390
ccoltx added a commit that referenced this issue Mar 29, 2021
@ccoltx
Cache mvn repo in main build (see #1677 )
57136ec
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Check path on windows for caching Maven
c882c3f
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Check path on windows for caching Maven
053bc55
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Check path on windows for caching Maven
2a5e441
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Show contents of settings.xml
2b4c5e0
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Using another Maven cache path for Windows
ba10a45
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Using latest cache action release explicitely (see egor-tensin…
85ea279 
…/cmake-common@eca875b and actions/toolkit#632)
jonashackt added a commit that referenced this issue Mar 30, 2021
@jonashackt
#1677: Also pinning the cache action at the main workflow
65211cb
@ccoltx
Copy link
Contributor Author

ccoltx commented Mar 30, 2021

There is an issue with the actions/cache@v2 version. The fix is included in actions/cache@v2.1.4. See:

https://www.gitmemory.com/issue/actions/toolkit/632/743759333
actions/toolkit#632 (comment)

ccoltx added a commit that referenced this issue Mar 30, 2021
@ccoltx @jonashackt
Cache mvn repo in main build (see #1677 ) (#1678)
d8d3038 
Cache maven repository to decrease build times (see #1677 )

* Using latest cache action release explicitly (see egor-tensin/cmake-common@eca875b and actions/toolkit#632)

Co-authored-by: Jonas Hecht <jonas.hecht@codecentric.de>
ccoltx added a commit that referenced this issue Mar 30, 2021
@ccoltx
Use maven repo cache during publish snapshots
d479c23 
Closes #1677
@ccoltx ccoltx mentioned this issue Mar 30, 2021
Merged
ccoltx added a commit that referenced this issue Mar 31, 2021
@ccoltx
Use maven repo cache during publish snapshots (#1687)
260fe11 
Closes #1677
@ccoltx ccoltx added this to the 2.4.1 milestone Mar 31, 2021
SteKoe added a commit to ParkerM/spring-boot-admin that referenced this issue Apr 16, 2021
@SteKoe
Merge remote-tracking branch 'origin/master' into fix/sample-resource…
b0c9da1 
…-relpaths

* origin/master:
  Add retry on failing subscription (codecentric#1697)
  chore(deps): update dependency pl.project13.maven:git-commit-id-plugin to v4.0.4 (codecentric#1663)
  chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.41.1 (codecentric#1648)
  Fix for codecentric#1638 (codecentric#1673)
  Improve npm ci build times (see codecentric#1688) (codecentric#1689)
  Improved execution of grouped assertions (codecentric#1674)
  Use maven repo cache during publish snapshots (codecentric#1687)
  chore(deps): update metcalfc/changelog-generator action to v1 (codecentric#1669)
  chore(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.2.7 (codecentric#1686)
  Fix file formating by applying spring-javaformat:apply (codecentric#1685)
  Cache mvn repo in main build (see codecentric#1677 ) (codecentric#1678)
  Added support DingTalk notifier. (codecentric#1653)
  Simplify some code (codecentric#1670)
  Bugfix/1646 (codecentric#1661)
  Upgrade spring cloud dependencies (codecentric#1645)
  chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.11.2 (codecentric#1635)
  chore(deps): update spring boot to v2.4.3 (codecentric#1637)
  Bump version to 2.4.1-SNAPSHOT
  chore(deps): update testcontainers.version to v1.15.2 (codecentric#1629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.4.1
Development

Successfully merging a pull request may close this issue.

Use maven repo cache during publish snapshots codecentric/spring-boot-admin
4 participants
@Riggs333 @jonashackt @joshiste @ccoltx