Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spring cloud dependencies to 2020.0.1 #1645

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Upgrade spring cloud dependencies to 2020.0.1 #1645

merged 1 commit into from
Mar 9, 2021

Conversation

antechrestos
Copy link

@antechrestos antechrestos commented Feb 25, 2021

Use 2020.0.1 (last) instead of 2020.0.0-M3.
This also brings kubernetes fabric8 client handle alongside with official one

Close #1644

@antechrestos antechrestos changed the title Upgrade spring cloud dependencies Upgrade spring cloud dependencies to 2020.0.1 Feb 25, 2021
@SteKoe
Copy link
Contributor

SteKoe commented Feb 26, 2021

Hi @antechrestos, thanks for your contribution! Can you please explain why you switched to fabric8 implementation? Which benefits do you see?

@antechrestos
Copy link
Author

antechrestos commented Feb 26, 2021

@SteKoe my bad. I've spotted that java kubernetes discovery client has been renamed. By the end of the day, I will push a version allowing user to choose its implementation (currently I am struggling with spring conditional ☺)

@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #1645 (999bc6f) into master (94d9d89) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1645      +/-   ##
============================================
- Coverage     83.72%   83.68%   -0.04%     
  Complexity     1203     1203              
============================================
  Files           151      151              
  Lines          3508     3512       +4     
  Branches        251      251              
============================================
+ Hits           2937     2939       +2     
- Misses          441      443       +2     
  Partials        130      130              
Impacted Files Coverage Δ Complexity Δ
.../config/AdminServerDiscoveryAutoConfiguration.java 84.61% <50.00%> (-15.39%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d9d89...999bc6f. Read the comment docs.

@antechrestos
Copy link
Author

@SteKoe Done. Opened to any feedback :)

* Use '2020.0.1' instead of '2020.0.0-M3'
* Allow handle of fabric8 kubernetes client

Close #1644
@antechrestos
Copy link
Author

@SteKoe Do you prefer I split my job in two distinct pull requests

  • one spring upgrade
    • the other one to allow user to use fabric 8 client?

@SteKoe
Copy link
Contributor

SteKoe commented Mar 5, 2021

Hey @antechrestos! We are currently working on integrating and testing your proposed changed :) There is no need to split the PR. Thanks again for your contribution and your patience!

@SteKoe SteKoe merged commit 35211dd into codecentric:master Mar 9, 2021
@antechrestos antechrestos deleted the features/upgrade-spring-cloud-dependencies branch March 9, 2021 08:06
SteKoe added a commit to ParkerM/spring-boot-admin that referenced this pull request Apr 16, 2021
…-relpaths

* origin/master:
  Add retry on failing subscription (codecentric#1697)
  chore(deps): update dependency pl.project13.maven:git-commit-id-plugin to v4.0.4 (codecentric#1663)
  chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.41.1 (codecentric#1648)
  Fix for codecentric#1638 (codecentric#1673)
  Improve npm ci build times (see codecentric#1688) (codecentric#1689)
  Improved execution of grouped assertions (codecentric#1674)
  Use maven repo cache during publish snapshots (codecentric#1687)
  chore(deps): update metcalfc/changelog-generator action to v1 (codecentric#1669)
  chore(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.2.7 (codecentric#1686)
  Fix file formating by applying spring-javaformat:apply (codecentric#1685)
  Cache mvn repo in main build (see codecentric#1677 ) (codecentric#1678)
  Added support DingTalk notifier. (codecentric#1653)
  Simplify some code (codecentric#1670)
  Bugfix/1646 (codecentric#1661)
  Upgrade spring cloud dependencies (codecentric#1645)
  chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.11.2 (codecentric#1635)
  chore(deps): update spring boot to v2.4.3 (codecentric#1637)
  Bump version to 2.4.1-SNAPSHOT
  chore(deps): update testcontainers.version to v1.15.2 (codecentric#1629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spring cloud depdencies to release version
3 participants