Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some code #1670

Merged
merged 1 commit into from Mar 26, 2021
Merged

Simplify some code #1670

merged 1 commit into from Mar 26, 2021

Conversation

zhaoyifan0528
Copy link

I found some code to simplify when using IDEA to inspect the code, so I submit a PR here.

@codecov-io
Copy link

Codecov Report

Merging #1670 (9203651) into master (5807037) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1670   +/-   ##
=========================================
  Coverage     83.69%   83.69%           
  Complexity     1203     1203           
=========================================
  Files           151      151           
  Lines          3514     3514           
  Branches        251      251           
=========================================
  Hits           2941     2941           
  Misses          443      443           
  Partials        130      130           
Impacted Files Coverage Δ Complexity Δ
...centric/boot/admin/server/ui/web/UiController.java 52.54% <0.00%> (ø) 10.00 <0.00> (ø)
...in/server/web/client/LegacyEndpointConverters.java 93.63% <100.00%> (ø) 57.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5807037...9203651. Read the comment docs.

@SteKoe SteKoe merged commit 1357b42 into codecentric:master Mar 26, 2021
SteKoe added a commit to ParkerM/spring-boot-admin that referenced this pull request Apr 16, 2021
…-relpaths

* origin/master:
  Add retry on failing subscription (codecentric#1697)
  chore(deps): update dependency pl.project13.maven:git-commit-id-plugin to v4.0.4 (codecentric#1663)
  chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.41.1 (codecentric#1648)
  Fix for codecentric#1638 (codecentric#1673)
  Improve npm ci build times (see codecentric#1688) (codecentric#1689)
  Improved execution of grouped assertions (codecentric#1674)
  Use maven repo cache during publish snapshots (codecentric#1687)
  chore(deps): update metcalfc/changelog-generator action to v1 (codecentric#1669)
  chore(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.2.7 (codecentric#1686)
  Fix file formating by applying spring-javaformat:apply (codecentric#1685)
  Cache mvn repo in main build (see codecentric#1677 ) (codecentric#1678)
  Added support DingTalk notifier. (codecentric#1653)
  Simplify some code (codecentric#1670)
  Bugfix/1646 (codecentric#1661)
  Upgrade spring cloud dependencies (codecentric#1645)
  chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.11.2 (codecentric#1635)
  chore(deps): update spring boot to v2.4.3 (codecentric#1637)
  Bump version to 2.4.1-SNAPSHOT
  chore(deps): update testcontainers.version to v1.15.2 (codecentric#1629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants