Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven repo cache during publish snapshots #1687

Merged
merged 1 commit into from Mar 31, 2021
Merged

Conversation

ccoltx
Copy link
Contributor

@ccoltx ccoltx commented Mar 30, 2021

Closes #1677

@ccoltx ccoltx added the dependencies Pull requests that update a dependency file label Mar 30, 2021
@ccoltx ccoltx added this to the 2.4.1 milestone Mar 30, 2021
@ccoltx ccoltx added enhancement and removed dependencies Pull requests that update a dependency file labels Mar 31, 2021
@ccoltx ccoltx self-assigned this Mar 31, 2021
@SteKoe SteKoe self-requested a review March 31, 2021 07:38
path: ~/.m2/repository
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is trailing dash required or would the following be sufficient as well? It looks a little bit weird compared to other pipeline definition files on GitLab or Azure. :)

${{ runner.os }}-build-${{ env.cache-name }}
${{ runner.os }}-build
${{ runner.os }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just followed the documentation. Probably not needed.
https://github.com/actions/cache/blob/main/examples.md#java---maven

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, then it looks good to me :) Nice work! Thank you very much!

@ccoltx ccoltx merged commit 260fe11 into master Mar 31, 2021
@ccoltx ccoltx deleted the feature/MvnCache branch March 31, 2021 08:20
SteKoe added a commit to ParkerM/spring-boot-admin that referenced this pull request Apr 16, 2021
…-relpaths

* origin/master:
  Add retry on failing subscription (codecentric#1697)
  chore(deps): update dependency pl.project13.maven:git-commit-id-plugin to v4.0.4 (codecentric#1663)
  chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.41.1 (codecentric#1648)
  Fix for codecentric#1638 (codecentric#1673)
  Improve npm ci build times (see codecentric#1688) (codecentric#1689)
  Improved execution of grouped assertions (codecentric#1674)
  Use maven repo cache during publish snapshots (codecentric#1687)
  chore(deps): update metcalfc/changelog-generator action to v1 (codecentric#1669)
  chore(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.2.7 (codecentric#1686)
  Fix file formating by applying spring-javaformat:apply (codecentric#1685)
  Cache mvn repo in main build (see codecentric#1677 ) (codecentric#1678)
  Added support DingTalk notifier. (codecentric#1653)
  Simplify some code (codecentric#1670)
  Bugfix/1646 (codecentric#1661)
  Upgrade spring cloud dependencies (codecentric#1645)
  chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.11.2 (codecentric#1635)
  chore(deps): update spring boot to v2.4.3 (codecentric#1637)
  Bump version to 2.4.1-SNAPSHOT
  chore(deps): update testcontainers.version to v1.15.2 (codecentric#1629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable github cache for mvn dependencies
2 participants