RetryFailedStep doesn't work with Retry, that was add in 3.4.1

[hatufacci]

Playwright use auto-waiting before start actions with elements https://playwright.dev/docs/actionability

It seems that this auto-waiting doesn't work in CodeceptJS version: 3.4.1

• CodeceptJS version: 3.4.1
• NodeJS Version: v18.14.0
• Operating System: Ubuntu 20.04.5 LTS
• Playwright
• Configuration file:

helpers: {
    Playwright: {
      url: process.env.FUNCTIONS_APP_URL,
      show: false,
      restart: true,
      video: true,
      trace: true,
      browser: "chromium",
      windowSize: "1440x900",
      waitForNavigation: "networkidle",
      waitForTimeout: 40000,
      timeout: 10000,
    },
}

[hatufacci]

there is no problem with "codeceptjs": "3.3.7",

[Nikoms]

Which playwright version are you using? I had the same problem than you with 3.4.1 and playwright:1.13 so I rolled back

[hatufacci]

i don't think it depends on playwright version "playwright": "1.30.0",

[Nikoms]

Me neither, but it's always good to know :)

[hatufacci]

@Nikoms do you use retryFailedStep plugin? :) i guess it's reason))))

[hatufacci]

the reason is that retryFailedStep not works properly in 3.4.1


than retryFailedStep must work!!!! and we go to

but in 3.4.1 we throw new ElementNotFound(locator, prefix, suffix); and that's it

[hatufacci]

After we throw new ElementNotFound we should go to ElementNotFound class

and after that error should be catch by
return Promise.race([promise, Promise.resolve(res).then(fn)]).finally(() => clearTimeout(timer)).catch((err) => { for (const retryObj of retryRules) { if (!retryObj.when) return retry(err); if (retryObj.when && retryObj.when(err)) return retry(err); } throw err;

but it doesn't

[Nikoms]

Yes, we use the retryFailedStep, good catch 🚀

[StanislavGrishaev]

same issue here, rollback to version 3.3.7 helped

[hatufacci]

It still the issue in 3.5.2 version :( @DavertMik could you please take a look on it?
3.3.7

3.5.2

[hatufacci]

@Nikoms @StasGrishaevTutu could you please check your config file ? do you have allure: { } plugin in it ?

[StanislavGrishaev]

@Nikoms @StasGrishaevTutu could you please check your config file ? do you have allure: { } plugin in it ?

hi there, in fact, I migrated from CodeceptJS to pure Playwright, so I can’t tell you anymore, unfortunately, sorry :)