Skip to content

(fix): ambiguous description on puppeteer helper #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 22, 2020
Merged

(fix): ambiguous description on puppeteer helper #2147

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
75a1e86
Streamlined return values from grab* (#2054)
Dec 6, 2019
94b2382
fix: replace console.print with console.log
atinux Dec 6, 2019
26b59a3
File system extended (#2034)
aefluke Dec 6, 2019
73e9a5a
fix: cannot grab for css attributes with hyphen (#2059)
Dec 6, 2019
e6453f0
Docs/remove jsdoc extra line (#2068)
elukoyanov Dec 8, 2019
538f0ac
fix: TestCafe grabAttributeFrom method not works (#2064)
elukoyanov Dec 8, 2019
e8a9fe9
#1911 - Regex for step Def file (#2043)
Dec 8, 2019
c1ebeff
Allows overriding default Polly config in MockRequest (#2060)
ecrmnn Dec 10, 2019
63180f0
Add Interoperable Code for supporting both CJS & ESM environments (#2…
kcak11 Dec 10, 2019
da214d9
fix(docs): add info about _after hook in helper
Vorobeyko Dec 12, 2019
8066e1a
lint fix
kobenguyent Dec 17, 2019
1a5453b
rebase with master
kobenguyent Jan 13, 2020
157552e
Merge branch 'master' of https://github.com/Codeception/CodeceptJS
kobenguyent Jan 13, 2020
d8b6cef
Merge branch 'master' of https://github.com/Codeception/CodeceptJS
kobenguyent Jan 17, 2020
639c707
fix the ambiguous description
kobenguyent Jan 17, 2020
8918130
CR fix
kobenguyent Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/helper/Puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,7 @@ async function proceedSee(assertType, text, context, strict = false) {
const locator = new Locator(context, 'css');
description = `element ${locator.toString()}`;
const els = await this._locate(locator);
assertElementExists(els, 'context element');
assertElementExists(els, locator.toString());
allText = await Promise.all(els.map(el => el.getProperty('innerText').then(p => p.jsonValue())));
}

Expand Down