Skip to content

(fix): some typos in custom-helpers.md #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2020
Merged

(fix): some typos in custom-helpers.md #2307

merged 2 commits into from
Apr 5, 2020

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Fix typos and rephrase some places.

Type of change

  • 🔨 Markdown files fix - not related to source code

pablopaul
pablopaul previously approved these changes Apr 1, 2020
View reviewed changes
@kobenguyent kobenguyent changed the title fix some typos (fix): some typos in custom-helpers.md Apr 2, 2020
elukoyanov
elukoyanov reviewed Apr 2, 2020
View reviewed changes
docs/custom-helpers.md Outdated
@@ -327,4 +327,4 @@ Retry rules are available in array `recorder.retries`. The last retry rule can b

## Using Typescript

When using typescript, replace `module.exports` with `export` for autocompletion.
When using Typescript, replacing `module.exports` with `export` for autocompletion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe when use Typescript, replace ?

elukoyanov
elukoyanov previously approved these changes Apr 2, 2020
View reviewed changes
DavertMik
DavertMik reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Maybe you have good ideas how to extend this?
I have a feeling that lots of things are missing here...

docs/custom-helpers.md Outdated
@@ -3,13 +3,13 @@ permalink: /helpers
title: Custom Helpers
---

# Extending CodeceptJS with Custom Helopers
# Extending CodeceptJS with custom helpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in title all words must be capitalized

@kobenguyent kobenguyent dismissed stale reviews from elukoyanov and pablopaul via 815b6c7 April 3, 2020 07:51
@github-actions
Copy link

github-actions bot commented Apr 3, 2020

🌀 Tests overview by Testomatio

Found 946 mocha tests in 74 files
No new tests added or removed

⚠️ List all skipped tests (1)
📎 List all suites (62)

@DavertMik DavertMik merged commit 1957d3d into master Apr 5, 2020
@DavertMik DavertMik deleted the PeterNgTr-patch-1 branch April 5, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik left review comments

@pablopaul pablopaul pablopaul left review comments

@elukoyanov elukoyanov elukoyanov left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobenguyent @DavertMik @pablopaul @elukoyanov