Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax grabCookie type #3919

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix: relax grabCookie type #3919

merged 1 commit into from
Oct 21, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added documentation typescript Changes for typings or typescript compatibility labels Oct 10, 2023
@kobenguyent kobenguyent linked an issue Oct 10, 2023 that may be closed by this pull request
Wrong typing for "grabCookie": should return "object" instead of "string" #3908
Closed
@Arhell Arhell requested a review from DavertMik October 11, 2023 00:20
@kobenguyent kobenguyent merged commit 73663de into 3.x Oct 21, 2023
9 checks passed
@kobenguyent kobenguyent deleted the 3908-wrong-typing-for-grabcookie-should-return-object-instead-of-string branch October 21, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
documentation typescript Changes for typings or typescript compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong typing for "grabCookie": should return "object" instead of "string"
2 participants
@kobenguyent @Arhell