Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appium helper docs update #3966

Merged
merged 5 commits into from
Nov 3, 2023
Merged

fix: appium helper docs update #3966

merged 5 commits into from
Nov 3, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Nov 1, 2023

Motivation/Description of the PR

The Appium core team does not maintain Appium 1.x anymore since the 1st of January 2022. Recent versions of all officially supported platform drivers are no longer compatible with Appium 1.x, and require Appium 2 to run.

  • This Appium 1.x support will be removed in next major release
  • Adding iOS Appium Tests

Applicable helpers:

  • Appium

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent changed the title fix: deprecate appium 1.x fix: appium helper docs update Nov 2, 2023
@kobenguyent kobenguyent merged commit bd79bb1 into 3.x Nov 3, 2023
14 checks passed
@kobenguyent kobenguyent deleted the appium-v1-deprecation branch November 3, 2023 11:53
@mirao
Copy link
Contributor

mirao commented Nov 11, 2023

I migrated from Appium 1.x to 2.x and was a bit confused that the message

The Appium core team does not maintain Appium 1.x anymore since the 1st of January 2022. Please migrating to Appium 2.x by adding appiumV2: true to your config.\nThis Appium 1.x support will be removed in next major release

is displayed even when I run a test with Appium 2.x (with appiumV2: true in a config).

Better would be to display the message only for Appium 1.x configurations.

@kobenguyent
Copy link
Collaborator Author

Thanks @mirao that sounds reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants