Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel execution by workers on multiple browsers results with multiple output folders #3971

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Nov 3, 2023

Motivation/Description of the PR

Screenshot 2023-11-04 at 10 49 56
Screenshot 2023-11-03 at 15 56 38

Type of change

  • 馃殌 New functionality

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

lib/workers.js Outdated
collection.createRuns(selectedRuns, config).forEach((worker) => {
const _config = { ...config };
_config.output = `${currentOutputFolder}/${worker.config.browser.browser}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ${worker.name} is better than ${worker.config.browser.browser}

Then an output folder name will be e.g. personal:chromium1 (or dev:chromium1) instead of chromium and it's more similar to naming when using run-multiple mode.

The run-multiple mode uses personal_chromium_1 (<profile>_<browser_name>_<browser_order>)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help tell what worker.name returns?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run a test in VSCode in debug mode and just saw the value. I guess "worker.name" returns <profile_name>:<browser_name>1.
Not sure for 1 means. I thought that it's a worker ID, but in my testing it's always 1 even for multiple workers (e.g. 2 workers).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, folder name is e.g. dev_firefox1 (profile "dev", browser "firefox") after the latest fixes 鉁旓笍 .
Also XML report result.xml is stored to a folder per browser 鉁旓笍 .

@kobenguyent kobenguyent added the cli label Nov 6, 2023
@kobenguyent kobenguyent merged commit b4ca718 into 3.x Nov 7, 2023
14 checks passed
@kobenguyent kobenguyent deleted the 3970-feature-request-parallel-execution-by-workers-on-multiple-browsers-results-with-multiple-output-folders branch November 7, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Parallel Execution by Workers on Multiple Browsers results with multiple output folders
2 participants