Skip to content

fix: missing exit condition #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: missing exit condition #3984

merged 1 commit into from
Nov 8, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • missing exit condition for waitForText which leads to the situation it waits until it reaches timeout.

Applicable helpers:

  • Playwright

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent mentioned this pull request Nov 7, 2023
Merged
6 tasks
@kobenguyent kobenguyent merged commit 9a102d2 into 3.x Nov 8, 2023
@kobenguyent kobenguyent deleted the fix-missing-exit-condition branch November 8, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

+1 more reviewer

@hatufacci hatufacci hatufacci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug playwright
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobenguyent @hatufacci @Arhell