Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: promise issue #4013

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix: promise issue #4013

merged 1 commit into from
Nov 20, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • Resolves #issueId (if applicable).

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added the typescript Changes for typings or typescript compatibility label Nov 20, 2023
@kobenguyent
Copy link
Collaborator Author

Published a beta version https://www.npmjs.com/package/codeceptjs/v/3.5.9-beta.1

Got the response that this fixed the issue https://codeceptjs.slack.com/archives/C94G8JXJB/p1700497852165699?thread_ts=1700148268.550579&channel=C94G8JXJB&message_ts=1700497852.165699

@kobenguyent kobenguyent merged commit e67c0c0 into 3.x Nov 20, 2023
12 checks passed
@kobenguyent kobenguyent deleted the fix-promise-issue branch November 20, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript Changes for typings or typescript compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kobenguyent