New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve the example code for autoLogin #4019

Merged

kobenguyent merged 1 commit into 3.x from improve-docs

Nov 22, 2023

Collaborator

kobenguyent commented Nov 22, 2023 •

edited

Loading

Motivation/Description of the PR

It may confuse users where to put the Before block, so this aims to improve the UX.
Resolves [Bug] Autologin hook called in Before(({ login }) causes "Cannot read properties of undefined (reading 'goto')" error in Playwright.amOnPage method #4002

Type of change

📋 Documentation changes/updates
🔨 Markdown files fix - not related to source code

Checklist:

Tests have been added
Documentation has been added (Run npm run docs)
Lint checking (Run npm run lint)
Local tests are passed (Run npm test)


          docs: improve the example code for autoLogin

2244fb3

kobenguyent added enhancement documentation labels

kobenguyent merged commit 1e5dd80 into 3.x

12 checks passed

kobenguyent deleted the improve-docs branch

November 22, 2023 14:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement