Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a locator builder method withTextEquals() #4100

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

mirao
Copy link
Contributor

@mirao mirao commented Jan 2, 2024

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

hey @mirao may you check if we could use those https://www.npmjs.com/package/csstoxpath?activeTab=explore#text functions from the lib with our withText or withTextEquals?

Refactored withText() and withTextEquals() to use csstoxpath
@mirao
Copy link
Contributor Author

mirao commented Jan 3, 2024

@kobenguyent Done. Please look at it.

@kobenguyent
Copy link
Collaborator

Thank you!

@kobenguyent kobenguyent merged commit b8b0e33 into codeceptjs:3.x Jan 3, 2024
12 checks passed
@kobenguyent kobenguyent mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add a locator builder method withTextEquals()
3 participants