Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use this.options instead of this.config #4186

Merged
merged 3 commits into from
Feb 10, 2024
Merged

fix: use this.options instead of this.config #4186

merged 3 commits into from
Feb 10, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • as we called this._setConfig() in helper, so using this.options would be the right one, as some places still call this.config

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 15142ea into 3.x Feb 10, 2024
12 checks passed
@kobenguyent kobenguyent deleted the fix-wrong-config-var-is-called branch February 10, 2024 19:32
@kobenguyent kobenguyent mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
webApi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kobenguyent @Arhell