-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): stale process #4367
Merged
Merged
fix(cli): stale process #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready for testing: codeceptjs@3.6.3-beta.2 |
Arhell
approved these changes
May 30, 2024
Horsty80
reviewed
Jun 3, 2024
4 tasks
* fix(webApi): error message of dontSeeCookie (#4357) * Fixed error message for dontSeeCookie() * fix(cli): gherkin command init with TypeScript (#4366) * DOC: Update contributor faces * fix(doc): Expect helper is not described correctly (#4370) * fix: Puppeteer helper doc typo (#4369) * chore(deps): bump devtools from 8.36.1 to 8.38.0 (#4374) * chore(deps-dev): bump playwright from 1.44.0 to 1.44.1 (#4376) Bumps [playwright](https://github.com/microsoft/playwright) from 1.44.0 to 1.44.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.44.0...v1.44.1) --- updated-dependencies: - dependency-name: playwright dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump axios from 1.6.7 to 1.7.2 (#4372) * chore(deps-dev): bump typedoc-plugin-markdown from 3.17.1 to 4.0.3 (#4373) * fix: handle throw error inside retryTo promise * fix: test due to update on retryTo plugin * fix: add a test case succeed after 2 retry --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Arthur Stankevich <a-stankevich@users.noreply.github.com> Co-authored-by: Ando NARY <36852616+andonary@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: KobeN <7845001+kobenguyent@users.noreply.github.com> Co-authored-by: Yoann Fleury <yoann.fleury@yahoo.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6 tasks
* chore: Add test:stale script for running state_test.js * fix: handle async function better to prevent stale the process * fix: done() call multiple times * chore: rename files and test description * fix: playwright error on test * fix: stale process due to retryTo error handler * fix: lint previous code * fix: error due to the previous merge * fix: handle async function better to prevent stale the process * fix: lint previous code --------- Co-authored-by: KobeN <7845001+kobenguyent@users.noreply.github.com>
ready for testing: codeceptjs@3.6.3-beta.3 |
DavertMik
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Looks good to me. Seems like a valid solution
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
From @Horsty80
When a throw error occurs inside promise, that stale the process, by rewrite with good reject and done call, we prevent this to happen
Resolves fix(cli): stale process #4367
maybe this pr can help this issue [Asking for help] Process are blocking when throw error in scenario with Retry enabled #4358
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)