Skip to content

fix: undefined string when using ucfirst #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix: undefined string when using ucfirst #4842

merged 2 commits into from
Feb 10, 2025

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Feb 10, 2025

Motivation/Description of the PR

  • fix: undefined string when using ucfirst
  • fix: retries is not a function in shell command

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@DavertMik
Copy link
Contributor

I fixed this in other way 8441f4f

ucfirst/lcfirst are correct, they should be applied only on string

@DavertMik DavertMik merged commit 04c06d1 into 3.x Feb 10, 2025
10 of 12 checks passed
@DavertMik DavertMik deleted the fix-issues-3.7.0 branch February 10, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants