Skip to content

Conversation

danielrentz
Copy link
Contributor

@danielrentz danielrentz commented Sep 30, 2025

Motivation/Description of the PR

The documentation of PupeteerConfig.waitForNavigation already says it: "Array values are accepted as well."

The commit hook seems to rewrite the entire formatting of puppeteer.md. After npm run docs and before committing, I have had a single changed line there.

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

looks like the doc link is deprecated. New one https://github.com/puppeteer/puppeteer/blob/main/docs/api/puppeteer.waitforoptions.md

@danielrentz
Copy link
Contributor Author

@kobenguyent

Thanks for the catch. I have tried to fix all other outdated GoogleChrome/puppeteer links as well.

There is only the one "Repository" link in docs/helpers/puppeteer-firefox.md that I could not resolve in the new repository.

Beside that, I found a broken link for Playwright's "waitForNavigation" that I have also fixed.

Can you tell me something about the completely rewritten formatting in the markdown files? Should I care about that?

@kobenguyent
Copy link
Collaborator

Can you tell me something about the completely rewritten formatting in the markdown files? Should I care about that?

@danielrentz per my best knowledge, those changes of markdown files are something we shall not worry about.

@kobenguyent kobenguyent merged commit 3e9b799 into codeceptjs:3.x Oct 1, 2025
14 checks passed
@danielrentz danielrentz deleted the patch-6 branch October 2, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants