Node crash if dimension mismatch in `I.seeVisualDiff`

[tairun]

• codeceptjs-resemblehelper: 1.6.0
• codeceptjs: 2.1.5
• node: 10.14.0

When using release 1.6.0 of this helper, node crashes with the following error if the dimension of the screenshots is not the same:

This is most likely due to the version of resemblejs being used. In the package.json the version specified is: ^3.0.0 which installs 3.2.0. A simple fix would be to always use 3.0.0, which worked for me.

[Kartikeya99]

That error is set by choice. Because if the dimensions aren't same then the tool behaves a bit unpredictably.

[tairun]

That error is set by choice. Because if the dimensions aren't same then the tool behaves a bit unpredictably.

I get that the diff-image produced by resemblejs with two images of different size isn't meaningful. But NODE crashes completely... which isn't a good thing. The error thrown should just cause the scenario to fail and then codeceptjs should get on with the next scenario. You still have the error in your tests about size mismatch in the end.

[tairun]

Instead of throwing error here, also reject(throw new Error(...)) with error... then it will also work with version 3.2.0 of resemblejs.

[Kartikeya99]

Which node version are you using?

[tairun]

To quote myself here:

* codeceptjs-resemblehelper: 1.6.0

* codeceptjs: 2.1.5

* node: 10.14.0

[pablopaul]

I ran into the same today.