Add Makefile, build image at generic name #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on the registry variable in the Circle env means this won't work on non-codeclimate forks. This also brings the engine in line with how we manage engine projects in general.
|
LGTM |
pbrisbin
added a commit
that referenced
this pull request
Mar 15, 2016
Add Makefile, build image at generic name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on the registry variable in the Circle env means this won't work on
non-codeclimate forks. This also brings the engine in line with how we manage
engine projects in general.
/cc @codeclimate/review
For some reason,
make testerrors for me locally because the container triesto write the
Gemfile.lock-- no idea why. I'm looking to see what happens onCircle (this specs-in-container approach has been working there since day 1).