This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Make config fetching safer #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeWilliams
force-pushed
the
bmw-config-tweaks
branch
from
e2f698f to
98e40f0
Compare
| end | ||
| end | ||
|
|
||
| def engine_languages | ||
| @engine_language ||= languages = engine_config. |
There was a problem hiding this comment.
what is languages used for?
There was a problem hiding this comment.
It's not, removing it.
|
Is the purpose of this changeset to be backwards compatible? |
|
Yes, and to prevent crashing when someone gives us an array of languages when they want to rely purely on the defaults. |
|
LGTM |
The current code makes a few assumptions about the format of your `.codeclimate.yml` which can cause the engine to crash. This changes the way we fetch the configuration to consider that not only may the keys not be present, but they might also not always be the type we expect.
BlakeWilliams
force-pushed
the
bmw-config-tweaks
branch
from
1595155 to
9a6f99c
Compare
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code makes a few assumptions about the format of your
.codeclimate.ymlwhich can cause the engine to crash.This changes the way we fetch the configuration to consider that not
only may the keys not be present, but they might also not always be the
type we expect.