This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Added AST dumping. #193
Merged
Added AST dumping. #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ast_dump:true to your .codeclimate.yml file's config. Running codeclimate will now output the AST to stderr, allowing you to figure out filter patterns for issues you don't care about. See README.md for more details.
gdiggs
reviewed
Jul 10, 2017
lib/cc/engine/analyzers/reporter.rb
Outdated
| @@ -93,8 +133,13 @@ def flay_options | |||
| CCFlay.default_options.merge changes | |||
| end | |||
|
|
|||
| def debug(message) | |||
| $stderr.puts(message) if engine_config.debug? | |||
| require "thread" | |||
There was a problem hiding this comment.
Can you move this require to the top of the file?
There was a problem hiding this comment.
Oops. It was actually already required (tho not sure why?). I also moved the constant up for clarity.
lib/cc/engine/analyzers/reporter.rb
Outdated
| def debug(message) | ||
| $stderr.puts(message) if engine_config.debug? | ||
| require "thread" | ||
| IO_M = Mutex.new |
There was a problem hiding this comment.
Can you move this constant declaration to the top of the class above def initialize?
lib/cc/engine/analyzers/reporter.rb
Outdated
|
|
||
| process_files | ||
|
|
||
| return dump_ast if engine_config.dump_ast? |
There was a problem hiding this comment.
💄 small formatting request:
if engine_config.dump_ast?
dump_ast
else
report
debug("Reported #{reports.size} violations...")
endThere was a problem hiding this comment.
Hah! I picked up that style from rubocop. Sure. I can change it to something more conventional.
|
This is up to date w/ the review now. |
Removes filter extension from CCFlay.
gdiggs
pushed a commit
that referenced
this pull request
Jul 21, 2017
* Added AST dumping. Add ast_dump:true to your .codeclimate.yml file's config. Running codeclimate will now output the AST to stderr, allowing you to figure out filter patterns for issues you don't care about. See README.md for more details. * Style changes per review. * Bumped to flay 2.10+ and ruby_parser 3.10+. Removes filter extension from CCFlay.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ast_dump:true to your .codeclimate.yml file's config.
Running codeclimate will now output the AST to stderr, allowing you to
figure out filter patterns for issues you don't care about.
See README.md for more details.