Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Add duplication engine analyzing ruby code #2

Merged
merged 16 commits into from
Sep 17, 2015
Merged

Add duplication engine analyzing ruby code #2

merged 16 commits into from
Sep 17, 2015

Conversation

jacooobi
Copy link
Contributor

@jacooobi jacooobi commented Sep 8, 2015

No description provided.

@mrb
Copy link
Contributor

mrb commented Sep 8, 2015

/cc @codeclimate/review

require 'flay'
require 'json'
require 'cc/engine/analyzers/helpers/main'
require 'pry'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental?

@jacooobi
Copy link
Contributor Author

jacooobi commented Sep 8, 2015

/cc @codeclimate/review

@mrb
Copy link
Contributor

mrb commented Sep 9, 2015

@codeclimate/review

@@ -0,0 +1,18 @@
FROM alpine:edge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use our internal tagged alpine image? Or does alpine themselves provide any tags besides "edge"? We've been bitten a couple times now by base images changing in ways that broke our images, so I feel like we should avoid relying on third-party "latest"/"edge" images.

mrb added a commit that referenced this pull request Sep 17, 2015
Add duplication engine analyzing ruby code
@mrb mrb merged commit 7e1e1e6 into codeclimate:master Sep 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants