Convert configured mass threshold to integer

[BlakeWilliams]

Currently a configured mass threshold will be returned as a string when
flay expects an integer when it tries to compare mass to mass threshold.

This also renames the assertion since the previous title was incorrect.

[gdiggs]

What happens when this returns nil? Do we default it somewhere?

[BlakeWilliams]

Yep, https://github.com/codeclimate/codeclimate-duplication/blob/master/lib/cc/engine/analyzers/analyzer_base.rb#L22

[jpignata]

Why isn't the YAML parsing properly casting this value to an integer?

[jpignata]

Do we have an upstream bug where we're incorrectly casting the value from an integer to a string in the YAML -> JSON translation?

[BlakeWilliams]

That may be it, by the time it gets to the mass_threshold_for it's a string.

    config:
      languages:
        ruby:
          mass_threshold: 15

Returns "15" when fetching it.

[BlakeWilliams]

For reference, when running YAML.load("foo: 15") you get 15 as an integer.

[pbrisbin]

I would have to guess it's this logic that introduced an incorrect cast within the "arbitrary" config node: codeclimate/codeclimate-yaml@5f6323f

[jpignata]

Being defensive here is probably right regardless so 👍 from me on this pull. I'll log a card to look at the upstream bug so it doesn't get lost.

[BlakeWilliams]

I also think being defensive is the best approach since it will work even if they pass mass_threshold: "15".

[gdiggs]

👍 as well