This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Ensure value is always defined before access #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In parsing some JSX from relax/relax, we noticed the parser was choking on trying to access attributes of the loc attribute of a given node. It looks like we were checking for the presence of value in every other branch so this change hoists that check up around the processing.
|
LGTM |
jpignata
added a commit
that referenced
this pull request
Oct 27, 2015
Ensure value is always defined before access
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parsing some JSX from relax/relax, we noticed the parser was choking
on trying to access attributes of the loc attribute of a given node. It
looks like we were checking for the presence of value in every other
branch so this change hoists that check up around the processing.