This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Don't show snippet in other locations #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dbd3a3f.
It's not always the first in `hashes`, but `current_sexp` uses the first of the sorted array, so dropping that one is safe. Covered by tests here: https://github.com/codeclimate/codeclimate-duplication/blob/master/spec/cc/engine/analyzers/javascript/main_spec.rb#L41-42
| @@ -33,7 +32,7 @@ def report_name | |||
|
|
|||
| private | |||
|
|
|||
| attr_reader :base_points, :hashes, :reports | |||
| attr_reader :base_points, :hashes | |||
|
|
|||
| def current_sexp | |||
| @location ||= sorted_hashes.first | |||
There was a problem hiding this comment.
This is where it uses sorted_hashes
|
Sample result |
|
Out of curiosity, can you try this with two duplicated lines of JSX? I think since that has multiple duplications in the same line |
|
LGTM |
|
👍 |
gdiggs
added a commit
that referenced
this pull request
Nov 10, 2015
Don't show snippet in other locations
|
@BlakeWilliams pasting that line twice worked correctly with these changes. Though, apparently 2 lines like that without a wrapping div is invalid JSX |
|
Cool, good to know. And yeah, JSX requires one top-level div. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the previous attempt to exclude the current snippet from
other_locations.It's not always the first in
hashes, butcurrent_sexpuses the firstof the sorted array, so dropping that one is safe.
Covered by tests here:
https://github.com/codeclimate/codeclimate-duplication/blob/master/spec/cc/engine/analyzers/javascript/main_spec.rb#L41-42
@codeclimate/review