eslint-plugin-import resolvers

[gilbarbara]

Hello!

Do you plan to add eslint-plugin-import resolvers for webpack (and node)?
It will be awesome since this plugin needs to resolve webpack aliases and modules for a complete analysis.

I'm almost disabling it completely since my apps rely on these features.

    checks:
      import/no-duplicates:
        enabled: false
      import/no-extraneous-dependencies:
        enabled: false
      import/no-named-as-default-member:
        enabled: false
      import/no-unresolved:
        enabled: false

Thanks

[dblandin]

Hey @gilbarbara,

I wasn't aware that some of the checks in eslint-plugin-import requires other npm modules.

Would you recommend bundling both https://www.npmjs.com/package/eslint-import-resolver-node and https://www.npmjs.com/package/eslint-import-resolver-webpack?

[gilbarbara]

Hey @dblandin

Yeah, I think it would be nice to have both since you'll need to customize the node resolver if you are requiring bower_components.

👍

[dblandin]

Sounds good to me. I'll open up a PR.

[dblandin]

Hey @gilbarbara,

I just released an update to the eslint-3 channel of this engine which includes the resolver npm packages added in #145.

Think you can give those checks another try via codeclimate.com or the CLI (after an engines:install)? Thanks!

[gilbarbara]

Hey @dblandin
It's working!
I tested locally with the CLI and removing all eslint-plugin-import rules that I had disabled in my config and no errors!

Yay! 🎉

[gilbarbara]

It's working on codeclimate.com too.

Awesome!

[dblandin]

Sweet! Glad it's working for you. Thanks for bringing this to our attention!

[dblandin]

Hey @gilbarbara,

We recently had to revert the change introducing the eslint-plugin-import resolvers due to node module resolution errors: #148

As stated in the PR, we may be able to reintroduce some the rules along with a new blacklist that ignores the problematic checks.

[fewieden]

what do you think about at least checking if the npm dependencies are listed in the package.json, this would do the job for me