Skip to content

Update package.json #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2016
Merged

Update package.json #107

merged 2 commits into from
Jul 21, 2016

Conversation

leftees
Copy link
Contributor

@leftees leftees commented Jul 21, 2016

Add support for eslint-config-angular plugin.

@gdiggs
Copy link
Contributor

gdiggs commented Jul 21, 2016

Should there be a change to the shrinkwrap json file too? cc @pbrisbin

@pbrisbin
Copy link
Contributor

Yes. As a process though, I think it's reasonable for the engineer to do that as part of picking this up from CX (WDYT?) -- I personally don't know how to update the shrinkwrap file :|

@pbrisbin
Copy link
Contributor

@gordondiggs updated and rebased. Added a make task to update the shrinkwrap using the engine image's npm too.

@gdiggs
Copy link
Contributor

gdiggs commented Jul 21, 2016

Nice LGTM

@pbrisbin pbrisbin merged commit 2f5cabf into pb-eslint-2 Jul 21, 2016
@pbrisbin pbrisbin deleted the js-eslint branch July 21, 2016 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants