Revert jsx-a11y upgrade to 5.0.0 #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblandin
approved these changes
May 11, 2017
|
cc/ @abbyarmada |
|
We've been getting a lot of inbound about the |
Gargron
pushed a commit
to mastodon/mastodon
that referenced
this pull request
May 19, 2017
In Code Climate, eslint-plugin-jsx-a11y v4.0.0 is used. Therefore, it seems that a warning is displayed. ref codeclimate/codeclimate-eslint#273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #271
The greenkeeper jsx-a11y upgrade to 5.0.0 is breaking compatibility with base configs such as airbnb. That is because they incorporated breaking changes such as rule renames.
I'm not sure why this was even allowed as an upgrade, given running
bin/yarnon master outputs unmet dependency warnings:We should hold off on the 5.0.0 upgrade until the base packages are upgraded to support 5.0.0. The previous version (4.0.0) has no dependency warnings.