Update to handle config.include_paths or config.exclude_paths. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Deprecated style of file expansion, supported for users of the old CLI. | ||
| return function(extensions) { | ||
| var analysisFiles = []; | ||
| var allFiles = glob.sync("/code/**/**", {}); |
There was a problem hiding this comment.
Isn't this the exact call that errors when something has restrictive permissions?
There was a problem hiding this comment.
EDIT: nevermind this is the deprecated function
| analysisFiles.push(file); | ||
| function isFileWithMatchingExtension(file, extensions) { | ||
| var stats = fs.lstatSync(file); | ||
| var extension = "." + file.split(".").pop(); |
There was a problem hiding this comment.
Any considering to be made for (e.g.) foo.tar.gz or index.html.slim?
There was a problem hiding this comment.
This line returns the last fragment in the string, i.e. .gz or .slim. So I think this is what we want. Even in a case where js is in the middle of the string, such as application.js.erb, we wouldn't to consider that analyzable by ESLint.
|
LGTM |
fhwang
added a commit
that referenced
this pull request
Sep 11, 2015
Update to handle config.include_paths or config.exclude_paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the time being, engines need to support both the old
include_pathsand the newexclude_pathskeys inconfig.json. This PR represents that requirement.