Skip to content

Update react plugin #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Update react plugin #45

merged 1 commit into from
Oct 27, 2015

Conversation

gdiggs
Copy link
Contributor

@gdiggs gdiggs commented Oct 27, 2015

@pbrisbin
Copy link
Contributor

LGTM, worth throwing in a compare URL or too noisy?

@gdiggs
Copy link
Contributor Author

gdiggs commented Oct 27, 2015

@pbrisbin done - good idea

gdiggs added a commit that referenced this pull request Oct 27, 2015
@gdiggs gdiggs merged commit 0cc9d06 into master Oct 27, 2015
@gdiggs gdiggs deleted the gd-react-update branch October 27, 2015 13:32
@pbrisbin
Copy link
Contributor

Cool. Not worth going back, but probably best to ammend those into the commit messages too. PRs are harder to track down after the fact IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants