Update dependencies #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` eslint@2.4.0 -> eslint@2.10.2 eslint-config-airbnb@6.0.2 -> eslint-config-airbnb@9.0.1 eslint-plugin-babel@2.1.1 -> eslint-config-airbnb@3.2.0 eslint-plugin-react@4.0.0 -> eslint-config-react@5.1.1 ```
| }, | ||
| "devDependencies": { | ||
| "chai": "^2.1.0", | ||
| "mocha": "^2.3.4", | ||
| "chai": "^3.5.0", |
There was a problem hiding this comment.
Should these be locked as well?
There was a problem hiding this comment.
I think the dev dependencies can be looser here since they're only used for the test suite.
There was a problem hiding this comment.
Cool - we've seen issues elsewhere with different versions of these being installed, but happy to address that whenever it comes up
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates this engine's npm dependencies for ESLint and our supported ESLint plugins. I've also added an npm shrinkwrap file to lock down the entire dependency tree.
@codeclimate/review 🔎